Reviewers: Kasper Lund, Description: Lint, schmlint!
Please review this at http://codereview.chromium.org/525114 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/codegen-arm.cc M src/ia32/codegen-ia32.cc M src/x64/codegen-x64.cc Index: src/ia32/codegen-ia32.cc =================================================================== --- src/ia32/codegen-ia32.cc (revision 3566) +++ src/ia32/codegen-ia32.cc (working copy) @@ -1934,7 +1934,7 @@ if (left_side.is_constant()) { left_side_constant_smi = left_side.handle()->IsSmi(); left_side_constant_null = left_side.handle()->IsNull(); - left_side_constant_1_char_string = + left_side_constant_1_char_string = (left_side.handle()->IsString() && (String::cast(*left_side.handle())->length() == 1)); } @@ -1944,7 +1944,7 @@ if (right_side.is_constant()) { right_side_constant_smi = right_side.handle()->IsSmi(); right_side_constant_null = right_side.handle()->IsNull(); - right_side_constant_1_char_string = + right_side_constant_1_char_string = (right_side.handle()->IsString() && (String::cast(*right_side.handle())->length() == 1)); } Index: src/x64/codegen-x64.cc =================================================================== --- src/x64/codegen-x64.cc (revision 3566) +++ src/x64/codegen-x64.cc (working copy) @@ -7756,7 +7756,7 @@ const char* CompareStub::GetName() { - switch(cc_) { + switch (cc_) { case less: return "CompareStub_LT"; case greater: return "CompareStub_GT"; case less_equal: return "CompareStub_LE"; Index: src/arm/codegen-arm.cc =================================================================== --- src/arm/codegen-arm.cc (revision 3566) +++ src/arm/codegen-arm.cc (working copy) @@ -4696,7 +4696,7 @@ __ mov(pc, Operand(lr)); // Return. } // No fall through here. - } + } __ bind(¬_identical); } @@ -6510,7 +6510,7 @@ const char* CompareStub::GetName() { - switch(cc_) { + switch (cc_) { case lt: return "CompareStub_LT"; case gt: return "CompareStub_GT"; case le: return "CompareStub_LE";
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
