Reviewers: Jakob,
Message:
PTAL. One other tiny corner case for total==0.
Description:
[test] Fix assert for predictable mode in test runner.
BUG=
Please review this at https://codereview.chromium.org/1156663009/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -2 lines):
M tools/testrunner/local/execution.py
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py
b/tools/testrunner/local/execution.py
index
e13393bf1c7626f1d64a48ab627e1f8dec1679aa..2b2f876d24f06a421853e41d24f2ab1be6d5acca
100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -255,8 +255,13 @@ class Runner(object):
if queued_exception:
raise queued_exception
- # Make sure that any allocations were printed in predictable mode.
- assert not self.context.predictable or self.printed_allocations
+ # Make sure that any allocations were printed in predictable mode (if
we
+ # ran any tests).
+ assert (
+ not self.total or
+ not self.context.predictable or
+ self.printed_allocations
+ )
def _VerbosePrint(self, text):
if self.context.verbose:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
