LGTM
It is not clear to me why the fast path does not work?
Can you file a bug about making freeze not use the slow path so that we do
not
forget about it later?
https://codereview.chromium.org/1142393003/diff/60001/test/mjsunit/strong/object-freeze-property.js
File test/mjsunit/strong/object-freeze-property.js (right):
https://codereview.chromium.org/1142393003/diff/60001/test/mjsunit/strong/object-freeze-property.js#newcode22
test/mjsunit/strong/object-freeze-property.js:22: return [({})];
no need for parens here.
https://codereview.chromium.org/1142393003/diff/60001/test/mjsunit/strong/object-freeze-property.js#newcode30
test/mjsunit/strong/object-freeze-property.js:30:
Object.defineProperty(o, "foo", { configurable:true, writable:true });
{configurable: true, writable: true}
https://codereview.chromium.org/1142393003/diff/60001/test/mjsunit/strong/object-freeze-property.js#newcode31
test/mjsunit/strong/object-freeze-property.js:31: assertDoesNotThrow(
assertDoesNotThrow is generally pretty useless... consider changing to
an IIFE.
https://codereview.chromium.org/1142393003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
