Reviewers: michael_dawson, Paul Lind,
Message:
PTAL
Description:
MIPS: Fix compile error for unitialized variable in simulator.
We see this error using GCC 4.8.2.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/1153213003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -6 lines):
M src/mips/simulator-mips.cc
M src/mips64/simulator-mips64.cc
Index: src/mips/simulator-mips.cc
diff --git a/src/mips/simulator-mips.cc b/src/mips/simulator-mips.cc
index
abddd910ce45aedd6816941cba52b2198b38b0fd..c5a6f7c3aa56b90f170124a712b46343179a3557
100644
--- a/src/mips/simulator-mips.cc
+++ b/src/mips/simulator-mips.cc
@@ -2454,9 +2454,8 @@ void
Simulator::DecodeTypeRegisterDRsType(Instruction* instr,
uint32_t cc, fcsr_cc;
int64_t i64;
fs = get_fpu_register_double(fs_reg);
- if (instr->FunctionFieldRaw() != MOVF) {
- ft = get_fpu_register_double(ft_reg);
- }
+ ft = (instr->FunctionFieldRaw() != MOVF) ?
get_fpu_register_double(ft_reg)
+ : 0.0;
fd = get_fpu_register_double(fd_reg);
int64_t ft_int = bit_cast<int64_t>(ft);
int64_t fd_int = bit_cast<int64_t>(fd);
Index: src/mips64/simulator-mips64.cc
diff --git a/src/mips64/simulator-mips64.cc b/src/mips64/simulator-mips64.cc
index
4b251f2b2fa037cbcbebe72d658bfde9ec66e18e..2025e43bd3ff8a077833bf3387971888907047f1
100644
--- a/src/mips64/simulator-mips64.cc
+++ b/src/mips64/simulator-mips64.cc
@@ -2994,9 +2994,8 @@ void
Simulator::DecodeTypeRegisterDRsType(Instruction* instr,
double ft, fs, fd;
uint32_t cc, fcsr_cc;
fs = get_fpu_register_double(fs_reg);
- if (instr->FunctionFieldRaw() != MOVF) {
- ft = get_fpu_register_double(ft_reg);
- }
+ ft = (instr->FunctionFieldRaw() != MOVF) ?
get_fpu_register_double(ft_reg)
+ : 0.0;
fd = get_fpu_register_double(fd_reg);
cc = instr->FCccValue();
fcsr_cc = get_fcsr_condition_bit(cc);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
