Looking good. Just one real comment.
https://codereview.chromium.org/1154163006/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1154163006/diff/20001/src/objects.cc#newcode11856
src/objects.cc:11856: os << " off hdlr (c)\n";
nit: I tried to be smart with the "(c)" in the header here, now that the
description is in each line, let's just drop the "(c)" from the header
again.
https://codereview.chromium.org/1154163006/diff/40001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/1154163006/diff/40001/src/isolate.h#newcode756
src/isolate.h:756: ExceptionPredictionMode prediction_mode =
PRECISE_PREDICTION);
As discussed offline: The only reason PredictExceptionCatcher exists, is
for the debugger. So if the debugger is only ever interested in the
CONSERVATIVE_PREDICTION, then we could just make that the default and
drop the PRECISE_PREDICTION altogether. WDYT?
https://codereview.chromium.org/1154163006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
