Reviewers: Erik Corry,

Description:
Fix wrong assert in compare stub minor key computation.

TBR=erik.corry

Please review this at http://codereview.chromium.org/536010

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/arm/codegen-arm.cc


Index: src/arm/codegen-arm.cc
===================================================================
--- src/arm/codegen-arm.cc      (revision 3572)
+++ src/arm/codegen-arm.cc      (working copy)
@@ -6563,7 +6563,7 @@

 int CompareStub::MinorKey() {
   // Encode the three parameters in a unique 16 bit value.
-  ASSERT(static_cast<unsigned>(cc_) < (1 << 14));
+  ASSERT((static_cast<unsigned>(cc_) >> 26) < (1 << 16));
   int nnn_value = (never_nan_nan_ ? 2 : 0);
   if (cc_ != eq) nnn_value = 0;  // Avoid duplicate stubs.
return (static_cast<unsigned>(cc_) >> 26) | nnn_value | (strict_ ? 1 : 0);


-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to