https://codereview.chromium.org/1131783003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1131783003/diff/1/src/heap/mark-compact.cc#newcode4627
src/heap/mark-compact.cc:4627: slot_type = SlotsBuffer::OBJECT_SLOT;
On 2015/06/01 09:52:08, rmcilroy wrote:
On 2015/05/20 22:28:22, mtbrandyberry wrote:
> On 2015/05/20 14:32:11, rmcilroy wrote:
> > why are these changes to add OBJECT_SLOT to the mark compact
collector
> required?
> > Can they be made in a different CL?
>
> This is required.
>
https://chromium.googlesource.com/v8/v8/+/7ad9980d995b0381046ee8677861491ef6d234ed
> effectively broke ool/embedded constant pools. I believe this
restores
> functionality without violating the intent of that change.
ishell@: Could you have a quick look at this change an check it won't
cause
issues with slot filtering again.
Sgtm. Since we have a typed slot here the slots filtering should not be
affected.
https://codereview.chromium.org/1131783003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
