LGTM with nits.
https://codereview.chromium.org/1163673003/diff/100001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1163673003/diff/100001/src/objects-inl.h#newcode3389
src/objects-inl.h:3389: CAST_ACCESSOR(GlobalDictionary)
nit: move before GlobalObject to maintain alpha-sorting
https://codereview.chromium.org/1163673003/diff/100001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1163673003/diff/100001/src/objects.cc#newcode16255
src/objects.cc:16255: PropertyDetails details = DetailsAt(i);
nit: while you're here, please fix indentation for the entire function.
https://codereview.chromium.org/1163673003/diff/100001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1163673003/diff/100001/src/objects.h#newcode3720
src/objects.h:3720:
nit: no double empty line required here
https://codereview.chromium.org/1163673003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
