https://codereview.chromium.org/1161073002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1161073002/diff/1/src/objects.cc#newcode3336
src/objects.cc:3336: return AddDataProperty(&own_lookup, value, NONE,
language_mode,
On 2015/06/01 14:37:03, Toon Verwaest wrote:
On 2015/06/01 14:17:58, arv wrote:
> AddDataProperty has a DCHECK that the receiver is not a proxy.
>
> Can found be false afte a proxy trap is invoked?
Not if the receiver is the proxy, as is the case here.
I think you'd want to make this switch nested in a for-loop like is the
case for other Set with iterator. After ruling out the interceptor /
access check, you just continue with whatever is behind the interceptor
/ access check. Behind the access check could be an interceptor. Behind
the interceptor could be data, or not-found.
https://codereview.chromium.org/1161073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
