Reviewers: Benedikt Meurer,
Message:
Note that this is still missing a unit test for the typed lowering part. I
will
add one, just wanted to get a first round of comments before/while I do so.
Thanks!
https://codereview.chromium.org/1150723005/diff/1/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/1150723005/diff/1/src/ast-numbering.cc#newcode158
src/ast-numbering.cc:158:
DisableCrankshaft(kReferenceToAVariableWhichRequiresDynamicLookup);
Please advise on whether I should land this together with this CL or
separate.
Description:
[turbofan] Optimized lowering of DYNAMIC_GLOBAL lookup slot loads.
This adds handling of JSLoadDynamicGlobal nodes to JSTypedLowering to
perform extension checks and an inline fast path. The fast path is a
global variable load from the global object.
[email protected]
BUG=v8:4131
LOG=N
Please review this at https://codereview.chromium.org/1150723005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+113, -35 lines):
M src/ast-numbering.cc
M src/compiler/ast-graph-builder.cc
M src/compiler/js-generic-lowering.cc
M src/compiler/js-operator.h
M src/compiler/js-operator.cc
M src/compiler/js-typed-lowering.h
M src/compiler/js-typed-lowering.cc
M src/compiler/operator-properties.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
