Reviewers: rossberg, wingo, arv, Dmitry Lomov (ooo until Jun 8), adamk,
Message:
Created Revert of [es6] implement default parameters via desugaring
Description:
Revert of [es6] implement default parameters via desugaring (patchset #19
id:380001 of https://codereview.chromium.org/1127063003/)
Reason for revert:
Broken on arm64
Original issue's description:
[es6] implement default parameters via desugaring
Stage 1 implementation:
- Parameters can't be referenced before initialized (from left-to-right)
- SingleNameBindings only, no support for BindingPatterns
Known issues:
- Incorrect scoping (parameter expressions may reference variables
declared in
function body)
- Function arity is untouched
- Hole-checking needs work
- Rest parameters are broken when mixed with optional arguments
BUG=v8:2160
LOG=N
[email protected], [email protected]
Committed: https://crrev.com/892c85485881f8be2f17bd83238980f858126576
Cr-Commit-Position: refs/heads/master@{#28739}
[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:2160
Please review this at https://codereview.chromium.org/1163853002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+30, -502 lines):
M src/bootstrapper.cc
M src/flag-definitions.h
M src/messages.h
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
M src/scopes.h
M src/scopes.cc
M src/variables.h
D test/mjsunit/harmony/default-parameters.js
D test/mjsunit/harmony/default-parameters-debug.js
D test/mjsunit/harmony/default-parameters-lazy.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
