LGTM modulo the vector on the operator, but that's probably separate.
https://codereview.chromium.org/1150723005/diff/1/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/1150723005/diff/1/src/ast-numbering.cc#newcode158
src/ast-numbering.cc:158:
DisableCrankshaft(kReferenceToAVariableWhichRequiresDynamicLookup);
I think that should go in separately.
https://codereview.chromium.org/1150723005/diff/1/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):
https://codereview.chromium.org/1150723005/diff/1/src/compiler/js-operator.h#newcode117
src/compiler/js-operator.h:117:
VectorSlotPair(Handle<TypeFeedbackVector> vector, FeedbackVectorICSlot
slot)
The vector should be an input to the node. The operator should only have
the constant slot. But I guess that should be cleanup work later since
it involves changes to the global load, which Michael Stanton is working
on as well.
https://codereview.chromium.org/1150723005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
