Reviewers: Benedikt Meurer,
Message:
On 2015/06/02 13:03:46, arv wrote:
One problem is that we still deopt on all super.prop and super() access
so in
practice the functions created by the class literals will not use TF.
See https://codereview.chromium.org/1149133005/ for TF super.prop. It has
some
failures that I need to look into but I have some more pressing work to
focus
on
before getting back to it.
Please note that this is about functions "containing a class literal" not
the
functions "making up a class literal".
Description:
[turbofan] Ship TF for class literals.
[email protected]
BUG=v8:4158
LOG=N
Committed: https://crrev.com/d71009a564f7bac8a8889cf66358ff6daeb4ae14
Cr-Commit-Position: refs/heads/master@{#28761}
Please review this at https://codereview.chromium.org/1158883006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/ast-numbering.cc
Index: src/ast-numbering.cc
diff --git a/src/ast-numbering.cc b/src/ast-numbering.cc
index
fe17ec363a2fa75a2f4d5e3c78a99c809c8bd10b..11e55e7baaeed55588617898830d712d3b7a8457
100644
--- a/src/ast-numbering.cc
+++ b/src/ast-numbering.cc
@@ -415,7 +415,7 @@ void
AstNumberingVisitor::VisitForStatement(ForStatement* node) {
void AstNumberingVisitor::VisitClassLiteral(ClassLiteral* node) {
IncrementNodeCount();
- DisableOptimization(kClassLiteral);
+ DisableCrankshaft(kClassLiteral);
node->set_base_id(ReserveIdRange(node->num_ids()));
if (node->extends()) Visit(node->extends());
if (node->constructor()) Visit(node->constructor());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
