On 2015/06/02 14:55:18, caitp wrote:
On 2015/06/02 12:47:23, caitp wrote:
> The output from --trace-turbo-graph looks generally okay (at least the
portions
> that I understand). So I'm not sure what's causing the arm64 sim test to
fail.
> https://gist.githubusercontent.com/caitp/20f4ba77fc0d03033552/raw/log
for a
> (big) log with --trace-turbo and --trace-turbo-graph.
mstarzinger@ I was wondering if you (or someone else familiar with TF)
might
be
able to shed some light on where this is going wrong on ARM64, or how I
could
determine it. The --trace-turbo-graph output for the function looks
correct,
but
we still end up with a kLetBindingReInitialization bailout, only on
ARM64, and
only with turbofan.
From IRC:
[12:03] <caitp> you know what
[12:04] <caitp> replacing `if (FLAG_debug_code && op == Token::INIT_LET) {`
with `if (generate_debug_code_ && op == Token::INIT_LET) {` in
full-codegen-arm64.cc fixes it
[12:04] <caitp> and matches the other arches better
[12:04] <caitp> derp
so... I assume that's just a bug in full-codegen-arm64 unless this was
written
this way on purpose?
https://codereview.chromium.org/1127063003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
