Reviewers: rmcilroy, Igor Sheludko, Rodolph Perfetta (ARM), mtbrandyberry,
Message:
Created Revert of Embedded constant pools.
Description:
Revert of Embedded constant pools. (patchset #12 id:220001 of
https://codereview.chromium.org/1131783003/)
Reason for revert:
Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP..
Original issue's description:
Add support for Embedded Constant Pools for PPC and Arm
Embed constant pools within their corresponding Code
objects.
This removes support for out-of-line constant pools in favor
of the new approach -- the main advantage being that it
eliminates the need to allocate and manage separate constant
pool array objects.
Currently supported on PPC and ARM. Enabled by default on
PPC only.
This yields a 6% improvment in Octane on PPC64.
[email protected], [email protected], [email protected],
[email protected], [email protected], [email protected]
BUG=chromium:478811
LOG=Y
Committed: https://crrev.com/a9404029343d65f146e3443f5280c40a97e736af
Cr-Commit-Position: refs/heads/master@{#28770}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:478811
Please review this at https://codereview.chromium.org/1155703006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2545, -1873 lines):
M include/v8.h
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
M src/arm/assembler-arm-inl.h
M src/arm/builtins-arm.cc
M src/arm/code-stubs-arm.cc
M src/arm/constants-arm.h
M src/arm/debug-arm.cc
M src/arm/deoptimizer-arm.cc
M src/arm/frames-arm.h
M src/arm/frames-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm64/assembler-arm64.h
M src/arm64/assembler-arm64.cc
M src/arm64/assembler-arm64-inl.h
M src/arm64/deoptimizer-arm64.cc
M src/arm64/frames-arm64.cc
M src/assembler.h
M src/assembler.cc
M src/compiler/arm/code-generator-arm.cc
M src/compiler/ppc/code-generator-ppc.cc
M src/debug.cc
M src/deoptimizer.cc
M src/factory.h
M src/factory.cc
M src/flag-definitions.h
M src/frames.h
M src/frames.cc
M src/globals.h
M src/heap-snapshot-generator.cc
M src/heap/heap.h
M src/heap/heap.cc
M src/heap/heap-inl.h
M src/heap/mark-compact.h
M src/heap/mark-compact.cc
M src/heap/objects-visiting.h
M src/heap/objects-visiting.cc
M src/heap/objects-visiting-inl.h
M src/heap/spaces.cc
M src/ia32/assembler-ia32.h
M src/ia32/assembler-ia32.cc
M src/ia32/assembler-ia32-inl.h
M src/ia32/deoptimizer-ia32.cc
M src/ia32/frames-ia32.cc
M src/ic/ic.h
M src/ic/ic.cc
M src/ic/ic-inl.h
M src/ic/ic-state.h
M src/ic/ic-state.cc
M src/ic/ppc/handler-compiler-ppc.cc
M src/lithium.cc
M src/macro-assembler.h
M src/mips/assembler-mips.h
M src/mips/assembler-mips.cc
M src/mips/deoptimizer-mips.cc
M src/mips/frames-mips.cc
M src/mips64/assembler-mips64.h
M src/mips64/assembler-mips64.cc
M src/mips64/deoptimizer-mips64.cc
M src/mips64/frames-mips64.cc
M src/objects.h
M src/objects.cc
M src/objects-debug.cc
M src/objects-inl.h
M src/objects-printer.cc
M src/ppc/assembler-ppc.h
M src/ppc/assembler-ppc.cc
M src/ppc/assembler-ppc-inl.h
M src/ppc/builtins-ppc.cc
M src/ppc/code-stubs-ppc.cc
M src/ppc/constants-ppc.h
M src/ppc/debug-ppc.cc
M src/ppc/deoptimizer-ppc.cc
M src/ppc/frames-ppc.h
M src/ppc/frames-ppc.cc
M src/ppc/full-codegen-ppc.cc
M src/ppc/lithium-codegen-ppc.cc
M src/ppc/macro-assembler-ppc.h
M src/ppc/macro-assembler-ppc.cc
M src/runtime/runtime-generator.cc
M src/snapshot/serialize.cc
M src/x64/assembler-x64.h
M src/x64/assembler-x64.cc
M src/x64/assembler-x64-inl.h
M src/x64/deoptimizer-x64.cc
M src/x64/frames-x64.cc
M src/x87/assembler-x87.h
M src/x87/assembler-x87.cc
M src/x87/assembler-x87-inl.h
M src/x87/deoptimizer-x87.cc
M src/x87/frames-x87.cc
M test/cctest/test-compiler.cc
M test/cctest/test-constantpool.cc
M test/cctest/test-reloc-info.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
