On 2010/01/12 14:24:24, Erik Corry wrote:
The caller is supposed to precompensate for memory that is wasted at the
end
of
pages. This seems onerous, but it's the sort of thing the snapshot code
already
needs to keep track of so it's not too bad. I will update the comments
accordingly.
OK
As for the large object space that is a little messy. In practice, a
context
snapshot won't contain many large objects and it may be OK to just fudge
it by
using an AlwaysAllocate scope around large object allocations. At least
there
are no issues with non-contiguous allocation.
As we discussed, the factor of 2 should be enough since the OS granularity
is
not part of our accounting.
LGTM
http://codereview.chromium.org/545026
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
