Fixes done in https://codereview.chromium.org/1163043003


https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js
File test/js-perf-test/Exceptions/try-catch.js (right):

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js#newcode16
test/js-perf-test/Exceptions/try-catch.js:16: WithFinallyOnException,
WithFinallyOnExceptionSetup, WithFinallyOnExceptionTearDown)
On 2015/06/03 14:10:00, arv wrote:
Long line

Done.

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js#newcode26
test/js-perf-test/Exceptions/try-catch.js:26: var a = 4;
On 2015/06/03 14:10:00, arv wrote:
What is the point of this setup function? It creates local variables
that are
never used.

*facepalm* fixed.

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js#newcode40
test/js-perf-test/Exceptions/try-catch.js:40: return c === 10;
On 2015/06/03 14:10:00, arv wrote:
This will return false because c is NaN

Done.

https://codereview.chromium.org/1155493007/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to