LGTM with one last comment on test.
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc#newcode248
test/cctest/test-heap.cc:248: CHECK(std::isnan(float32x4->get_lane(2)));
Can we also check that writing to one lane doesn't overwrite the other
lanes?
https://codereview.chromium.org/1153373003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
