https://codereview.chromium.org/1155043005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1155043005/diff/1/src/api.cc#newcode7214
src/api.cc:7214: if (index > i::LAST_SPACE || (i::FIRST_SPACE > 0 &&
index < i::FIRST_SPACE))
The way I read globals.h, i::FIRST_SPACE would usually be 0, meaning
this effectively eliminates the 2nd condition.
Also, I'm not really sure why this would be the right place to make an
assertion about the i::FIRST_SPACE constant in the first place.
Would you care to explain a bit more what you're trying to do? I'm
afraid I don't quite get it.
https://codereview.chromium.org/1155043005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
