On 2010/01/13 02:19:22, piman wrote:
On 2010/01/12 11:11:13, Søren Gjesse wrote:
> On 2010/01/12 08:42:17, piman wrote:
> > http://codereview.chromium.org/549018/diff/1/2
> > File tools/gyp/v8.gyp (right):
> >
> > http://codereview.chromium.org/549018/diff/1/2#newcode200
> > tools/gyp/v8.gyp:200: # The ARM assembler assumes the host is 32
bits, so
> force
> > building
> > On 2010/01/12 08:20:41, Søren Gjesse wrote:
> > > Shouldn't this "ARM assembler" be "ARM simulator"?
> >
> > assembler-arm-inl.h is the file that fails to compile if -m32 isn't
on.
>
> Thats right, but if we are compiling the ARM assembler for a x64 target
it
> implies that the ARM simulator will be used to execute the code it will
> generate. Anyway keep the comment as is as mentioning the simulator
might
create
> more confusion.
Ok. Do you mind checking this one in as well ? Thanks !
Landed through http://codereview.chromium.org/546030.
http://codereview.chromium.org/549018
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
