LGTM with nits.
https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi#newcode341
build/toolchain.gypi:341: ['v8_target_arch==target_arch and
(v8_target_arch=="mips" or \
nit: I'd prefer if you could reorder the conditions (checking "... and
v8_target_arch==target_arch" last), so it's quicker to see that this
block is MIPS specific.
https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi#newcode359
build/toolchain.gypi:359: ]
nit: trailing ',' for consistency.
https://codereview.chromium.org/1160973006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
