https://codereview.chromium.org/1149133005/diff/100001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1149133005/diff/100001/src/compiler/ast-graph-builder.cc#newcode2219
src/compiler/ast-graph-builder.cc:2219: Node* value;
It is not clear that 'value' will always be initialized before it is
used by this function. This will be true as long as GetAssignType()
always returns one of the five values listed in the switch statement and
this may not be a long-term stable assumption.
Consider initializing value to nullptr when it is declared, thus making
it trivially obvious that it is always initialized. This is virtually
free.
https://codereview.chromium.org/1149133005/diff/100001/src/compiler/ast-graph-builder.cc#newcode2225
src/compiler/ast-graph-builder.cc:2225: value = nullptr;
i.e.; move this assignment to the variable declaration.
https://codereview.chromium.org/1149133005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
