Reviewers: jochen,
Message:
If possible, can you land this for me?
Description:
Make v8 snapshot public in component build.
This was already public in a non-component build. This means that targets
dependent on the "v8" target can take the results of the snapshot as inputs.
This also renames the component mode checking from keying off of the
component_mode string to checking the is_component_build flag, which is now
the
recommended way to do this check.
Please review this at https://codereview.chromium.org/1167223002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -3 lines):
M BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
cffd8f07557bc37835304d8d1564adbc4e0c4111..2f108d0803ef0e3995288f9ba1d2d3ecfa8a01bb
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -52,7 +52,7 @@ config("internal_config") {
include_dirs = [ "." ]
- if (component_mode == "shared_library") {
+ if (is_component_build) {
defines = [
"V8_SHARED",
"BUILDING_V8_SHARED",
@@ -1567,7 +1567,7 @@ if (current_toolchain == snapshot_toolchain) {
# Public targets
#
-if (component_mode == "shared_library") {
+if (is_component_build) {
component("v8") {
sources = [
"src/v8dll-main.cc",
@@ -1576,6 +1576,8 @@ if (component_mode == "shared_library") {
if (v8_use_snapshot && v8_use_external_startup_data) {
deps = [
":v8_base",
+ ]
+ public_deps = [
":v8_external_snapshot",
]
} else if (v8_use_snapshot) {
@@ -1672,7 +1674,7 @@ if ((current_toolchain == host_toolchain &&
v8_toolset_for_d8 == "host") ||
sources += [ "src/d8-windows.cc" ]
}
- if (component_mode != "shared_library") {
+ if (!is_component_build) {
sources += [
"src/d8-debug.cc",
"$target_gen_dir/d8-js.cc",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
