LGTM

I'm not sure how to test Set throwing? I don't see how it can throw?


https://codereview.chromium.org/1170023002/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):

https://codereview.chromium.org/1170023002/diff/1/src/harmony-typedarray.js#newcode351
src/harmony-typedarray.js:351: // does this throw?
If you make this function strict you should get the exception as needed.

https://codereview.chromium.org/1170023002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.
  • [v8-dev] Re: Imp... arv
    • [v8-dev] Re... 'commit-bot: I haz the power' via codereview.chromium.org
    • [v8-dev] Re... 'commit-bot: I haz the power' via codereview.chromium.org
    • [v8-dev] Re... 'commit-bot: I haz the power' via codereview.chromium.org
    • [v8-dev] Re... machenbach
      • [v8-dev... 'Daniel Vogelheim' via v8-dev
        • [v8... 'Daniel Vogelheim' via v8-dev
          • ... 'Daniel Vogelheim' via v8-dev
            • ... 'Daniel Vogelheim' via v8-dev
            • ... Sven Panne

Reply via email to