On 2015/06/09 10:59:35, Yang wrote:
https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):
https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc#newcode4920
src/jsregexp.cc:4920: new (zone) RegExpAtom(suffix_list->ToConstVector());
We could just use old_atom->data()->SubVector(1, len) instead of creating
it
from a list.
But I wonder whether we could just reuse the old RegExpAtom instances?
https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc#newcode5000
src/jsregexp.cc:5000: return alternatives->at(0)->ToNode(compiler,
on_success);
I guess for something like aaaaaaaaaaaaaaab|aaaaaaaaaaaaaaac|
aaaaaaaaaaaaaaad
this would lead to running rationalize 15 times, each time producing one
character of prefix?
Otherwise lgtm.
https://codereview.chromium.org/1176453002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
