Looking good, mostly nits.
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/ast-graph-builder.cc#newcode3451
src/compiler/ast-graph-builder.cc:3451: Node*
AstGraphBuilder::BuildKeyedLoad(Node* object, Node* key, Node* vector,
nit: Instead of passing the vector as an argument, let's just call
GetFeedbackVector() within this helper.
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/ast-graph-builder.cc#newcode3459
src/compiler/ast-graph-builder.cc:3459: Node*
AstGraphBuilder::BuildNamedLoad(Node* object, Node* vector,
nit: Likewise.
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/ast-graph-builder.h#newcode240
src/compiler/ast-graph-builder.h:240: ResolvedFeedbackSlot
CreateResolvedFeedbackSlot(
nit: We could just call the function "ResolveFeedbackSlot" instead.
WDYT?
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):
https://codereview.chromium.org/1175503002/diff/20001/src/compiler/js-operator.h#newcode115
src/compiler/js-operator.h:115: // A FeedbackVectorICSlot needs to query
the type feedback vector to get it's
nit: s/FeedbackVectorICSlot/ResolvedFeedbackSlot/ in the comment.
https://codereview.chromium.org/1175503002/diff/20001/test/unittests/compiler/js-typed-lowering-unittest.cc
File test/unittests/compiler/js-typed-lowering-unittest.cc (right):
https://codereview.chromium.org/1175503002/diff/20001/test/unittests/compiler/js-typed-lowering-unittest.cc#newcode691
test/unittests/compiler/js-typed-lowering-unittest.cc:691:
nit: Drop the empty newline for consistency.
https://codereview.chromium.org/1175503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
