Reviewers: ulan, digit1, Torne,
Message:
On 2015/06/09 11:52:59, Torne wrote:
Is this still needed? If so then WebView is no longer a special case as
we now
only build it using the standard chromium build process.
As of this change https://codereview.chromium.org/1140503004, the default
is now
'hardfp' for linux and 'softfp' for android. So we have defaults that
work and
most people should not need to set arm_float_abi in their GYP_DEFINES.
Although its a little inelegant to have to set this at all (we should rely
on
the compiler), what we have now at least works as expected in most cases,
so I'm
happy to drop this change.
Description:
Define USE_EABI_HARDFLOAT when arm_float_abi is 'default'.
This is in line with pending changes to chrome build using
armhf compiler by default and leave arm_float_abi empty.
Also, allow the arm_float_abi gyp variable to be left as
empty to signal the compiler default (i.e. no argument
passed to the compiler) to be consistent with chrome's
common.gypi.
BUG=308256
Please review this at https://codereview.chromium.org/48113015/
Base URL: git://github.com/v8/v8.git@master
Affected files (+6, -6 lines):
M build/toolchain.gypi
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
de41fe0d00189e2a20576c63004e21a6ad14a9d8..05c0258927d50465d6506f8dbbb067b86c1a87e9
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -109,7 +109,7 @@
}],
],
}],
- [ 'arm_float_abi!="default"', {
+ [ 'arm_float_abi!="default" and arm_float_abi!=""', {
'cflags': ['-mfloat-abi=<(arm_float_abi)',],
}],
[ 'arm_thumb==1', {
@@ -156,12 +156,12 @@
}],
],
}],
- [ 'arm_float_abi=="hard"', {
+ [ 'arm_float_abi=="hard" or arm_float_abi=="default" or
arm_float_abi==""', {
'defines': [
'USE_EABI_HARDFLOAT=1',
],
}],
- [ 'arm_float_abi=="softfp" or arm_float_abi=="default"',
{
+ [ 'arm_float_abi=="softfp"', {
'defines': [
'USE_EABI_HARDFLOAT=0',
],
@@ -197,7 +197,7 @@
}],
],
}],
- [ 'arm_float_abi!="default"', {
+ [ 'arm_float_abi!="default" and arm_float_abi!=""', {
'cflags': ['-mfloat-abi=<(arm_float_abi)',],
}],
[ 'arm_thumb==1', {
@@ -244,12 +244,12 @@
}],
],
}],
- [ 'arm_float_abi=="hard"', {
+ [ 'arm_float_abi=="hard" or arm_float_abi=="default" or
arm_float_abi==""', {
'defines': [
'USE_EABI_HARDFLOAT=1',
],
}],
- [ 'arm_float_abi=="softfp" or arm_float_abi=="default"',
{
+ [ 'arm_float_abi=="softfp"', {
'defines': [
'USE_EABI_HARDFLOAT=0',
],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
