https://codereview.chromium.org/1178523002/diff/20001/src/expression-classifier.h
File src/expression-classifier.h (right):
https://codereview.chromium.org/1178523002/diff/20001/src/expression-classifier.h#newcode40
src/expression-classifier.h:40: ArrowFormalParametersWithRestProduction
= 1 << 7,
I am not too happy about this irregularity. We aro no longer using the
classifier to report errors, but also to propagate information.
How about this: afaiu this bit is only used in parser, and parser can
just analyze the ASt directly to see if the last parameter is a spread
operation or not. WDYT?
https://codereview.chromium.org/1178523002/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1178523002/diff/20001/src/parser.cc#newcode3811
src/parser.cc:3811: if (!duplicate_loc->IsValid()) {
Oops, thanks for fixing this! Can we add a test that fails without this
fix? (ok in separate CL)
https://codereview.chromium.org/1178523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
