Reviewers: Benedikt Meurer,
Description:
[turbofan] Enable support for try-catch statements.
[email protected]
BUG=v8:4131
LOG=N
Please review this at https://codereview.chromium.org/1177743002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -1 lines):
M src/flag-definitions.h
M test/mjsunit/mjsunit.status
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
b2f2b9963f9cd73b52ff7a21988cbea7ff1f61e7..0d13bf479fbd91a8c79ecb89517e67a955d3bd37
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -423,7 +423,7 @@ DEFINE_BOOL(turbo_verify_allocation, DEBUG_BOOL,
DEFINE_BOOL(turbo_move_optimization, true, "optimize gap moves in
TurboFan")
DEFINE_BOOL(turbo_jt, true, "enable jump threading in TurboFan")
DEFINE_BOOL(turbo_osr, true, "enable OSR in TurboFan")
-DEFINE_BOOL(turbo_try_catch, false, "enable try-catch support in TurboFan")
+DEFINE_BOOL(turbo_try_catch, true, "enable try-catch support in TurboFan")
DEFINE_BOOL(turbo_try_finally, false, "enable try-finally support in
TurboFan")
DEFINE_BOOL(turbo_stress_loop_peeling, false,
"stress loop peeling optimization")
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
b87bfbe0415a2481bb92c0522e15e94b827106c4..b79357dd3b14ad3bcc08af1ea938f85eee30dd27
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -62,6 +62,11 @@
# from the deoptimizer to do that.
'arguments-indirect': [PASS, NO_VARIANTS],
+ # TODO(mstarzinger): The implicit JSToNumber and JSToString nodes
inserted by
+ # JSTypedLowering are not properly connected to a surrounding exceptional
+ # continuation yet, hence exception are thrown out of the function body.
+ 'regress/regress-1327557': [PASS, NO_VARIANTS],
+
# TODO(verwaest): Some tests are over-restrictive about object layout.
'array-constructor-feedback': [PASS, NO_VARIANTS],
'array-feedback': [PASS, NO_VARIANTS],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
