Reviewers: jochen,
Description:
Always print external time in --trace-gc to make it toolable.
BUG=
Please review this at https://codereview.chromium.org/1173243003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -3 lines):
M src/heap/gc-tracer.cc
Index: src/heap/gc-tracer.cc
diff --git a/src/heap/gc-tracer.cc b/src/heap/gc-tracer.cc
index
6ca724e5a1ef18158fa1b436f69ca5149df5ec80..4f5b5ae517a734efd01b79cfb5d4a317e810fe79
100644
--- a/src/heap/gc-tracer.cc
+++ b/src/heap/gc-tracer.cc
@@ -360,10 +360,9 @@ void GCTracer::Print() const {
static_cast<double>(current_.end_memory_size) / MB);
int external_time = static_cast<int>(current_.scopes[Scope::EXTERNAL]);
- if (external_time > 0) Output("%d / ", external_time);
-
double duration = current_.end_time - current_.start_time;
- Output("%.1f ms", duration);
+ Output("%.1f / %d ms", duration, external_time);
+
if (current_.type == Event::SCAVENGER) {
if (current_.incremental_marking_steps > 0) {
Output(" (+ %.1f ms in %d steps since last GC)",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
