Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: Vector ICs: debugger should save registers for vector store ics.
port bd32a9f711cb14c2b7c34512d43e78bd24960124 (r28825).
original commit message:
BUG=
Please review this at https://codereview.chromium.org/1173963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -7 lines):
M src/x87/debug-x87.cc
Index: src/x87/debug-x87.cc
diff --git a/src/x87/debug-x87.cc b/src/x87/debug-x87.cc
index
865ca8b4c9e088cfdaf630fee27a92d6c439e06f..43974d2d9aacbc8d75e3d3827941d5a51fd70972
100644
--- a/src/x87/debug-x87.cc
+++ b/src/x87/debug-x87.cc
@@ -193,8 +193,11 @@ void
DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
Register receiver = StoreDescriptor::ReceiverRegister();
Register name = StoreDescriptor::NameRegister();
Register value = StoreDescriptor::ValueRegister();
- Generate_DebugBreakCallHelper(
- masm, receiver.bit() | name.bit() | value.bit(), 0, false);
+ RegList regs = receiver.bit() | name.bit() | value.bit();
+ if (FLAG_vector_stores) {
+ regs |= VectorStoreICDescriptor::SlotRegister().bit();
+ }
+ Generate_DebugBreakCallHelper(masm, regs, 0, false);
}
@@ -206,11 +209,7 @@ void
DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
// Register state for keyed IC store call (from ic-x87.cc).
- Register receiver = StoreDescriptor::ReceiverRegister();
- Register name = StoreDescriptor::NameRegister();
- Register value = StoreDescriptor::ValueRegister();
- Generate_DebugBreakCallHelper(
- masm, receiver.bit() | name.bit() | value.bit(), 0, false);
+ GenerateStoreICDebugBreak(masm);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
