Thanks for comments.
I changed the description and uploaded new patch set.
https://codereview.chromium.org/1163143009/diff/210001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):
https://codereview.chromium.org/1163143009/diff/210001/src/heap/gc-tracer.cc#newcode622
src/heap/gc-tracer.cc:622: const double kEpsilon = 0.5;
On 2015/06/11 01:33:57, Hannes Payer wrote:
Can we rename epsilon to kMinimumMarkingSpeed (or something more
descriptive)?
Done.
https://codereview.chromium.org/1163143009/diff/210001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1163143009/diff/210001/src/heap/heap.cc#newcode5305
src/heap/heap.cc:5305: // https://goo.gl/LLGvBs.
On 2015/06/11 01:33:57, Hannes Payer wrote:
Instead of posting a link, can we add the necessary details here? I am
fine with
spending several lines on comments.
Done.
https://codereview.chromium.org/1163143009/diff/210001/src/heap/heap.cc#newcode5310
src/heap/heap.cc:5310: if (max_old_generation_size_ <=
kMaxOldSpaceSizeMediumMemoryDevice) {
On 2015/06/11 01:33:57, Hannes Payer wrote:
If we would not access max_old_generation_size_, this function would
be
unit-testable? WDYT? Having tests for the function would be nice.
Done. The first function to be unit-tested in Heap :)
https://codereview.chromium.org/1163143009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
