Reviewers: Benedikt Meurer, ulan,
Message:
Created Revert of [arm64][turbofan]: Handle any immediate shift.
Description:
Revert of [arm64][turbofan]: Handle any immediate shift. (patchset #1 id:1
of
https://codereview.chromium.org/1179733004/)
Reason for revert:
Breaks InstructionSelectorTest.Word64ShrWithWord64AndWithImmediate on debug
builds (but not optdebug builds). I'll investigate.
Original issue's description:
[arm64][turbofan]: Handle any immediate shift.
With this patch, we can generate simple immediate-shift instructions for
immediates outside the range "0 <= imm < width". Several related
instruction selectors have also been updated accordingly.
Example of generated code:
---- Before --- ---- After ----
movz w0, #33 lsr w0, w1, #1
lsr w0, w1, w0
BUG=
Committed: https://crrev.com/36d771bbfa4af5efcc1c1dcf5b234445cb7ee722
Cr-Commit-Position: refs/heads/master@{#28943}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1176393002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+100, -136 lines):
M src/compiler/arm64/code-generator-arm64.cc
M src/compiler/arm64/instruction-selector-arm64.cc
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
