Reviewers: Søren Gjesse,
Message:
Hi Sorren
This change is very minor one. One spelling fix and also I thought that no
being
able to open port for listening should not be quietly ignored. Instead, it
cries
about it each minute.
I don't know whether you find it usable.
Peter
Description:
Add diagnostic print to debug agent if it fails to open port
Please review this at http://codereview.chromium.org/549061
Affected files:
M src/debug-agent.cc
Index: src/debug-agent.cc
diff --git a/src/debug-agent.cc b/src/debug-agent.cc
index
070138254cf5691bf77752d23d796310b8c347f8..41151d8076c49bce3358bba12fffc3245b90bb13
100644
--- a/src/debug-agent.cc
+++ b/src/debug-agent.cc
@@ -54,10 +54,12 @@ void DebuggerAgent::Run() {
while (!bound && !terminate_) {
bound = server_->Bind(port_);
- // If an error occoured wait a bit before retrying. The most common
error
+ // If an error occurred wait a bit before retrying. The most common
error
// would be that the port is already in use so this avoids a busy loop
and
// make the agent take over the port when it becomes free.
if (!bound) {
+ PrintF("Failed to open socket on port %d, "
+ "waiting %d ms before retrying\n", port_, kOneSecondInMicros /
1000);
terminate_now_->Wait(kOneSecondInMicros);
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
