LGTM with nits
https://codereview.chromium.org/1181623003/diff/1/test/mjsunit/harmony/array-from.js
File test/mjsunit/harmony/array-from.js (right):
https://codereview.chromium.org/1181623003/diff/1/test/mjsunit/harmony/array-from.js#newcode170
test/mjsunit/harmony/array-from.js:170: })();
On 2015/06/11 16:27:25, littledan wrote:
On 2015/06/11 13:04:01, arv wrote:
> I see that there is already a test for accessors on Array.prototype.
Not sure what you're referring to, but I added a test.
Ignore me.
https://codereview.chromium.org/1181623003/diff/20001/test/mjsunit/harmony/array-from.js
File test/mjsunit/harmony/array-from.js (right):
https://codereview.chromium.org/1181623003/diff/20001/test/mjsunit/harmony/array-from.js#newcode160
test/mjsunit/harmony/array-from.js:160: // Check that exotic was defined
right
I would remove this (line 160-165). We have plenty of tests making sure
accessors works correctly ;-)
https://codereview.chromium.org/1181623003/diff/20001/test/mjsunit/harmony/array-from.js#newcode166
test/mjsunit/harmony/array-from.js:166: // Accessor properties can't be
overwritten with DefineOwnProperty
This comment is wrong. The reason why is because you created the
property as non configurable.
https://codereview.chromium.org/1181623003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
