Comment #14 on issue 4137 by [email protected]: Support elements in the LookupIterator
https://code.google.com/p/v8/issues/detail?id=4137#c14
The following revision refers to this bug:https://chromium.googlesource.com/v8/v8.git/+/62d65a347f6cbd7f1553b20dda9aacab6f0690cf
commit 62d65a347f6cbd7f1553b20dda9aacab6f0690cf Author: ishell <[email protected]> Date: Thu Jun 11 17:21:11 2015Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/)
Reason for revert: Blocks revert of https://codereview.chromium.org/1175973002 Original issue's description:
Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant.
@yangguo: please look at the debugger part of the CL. @ishell: please look at the rest.
Additionally:- Ensure the LookupIterator for named properties does not accidentally get indexes in. - Fix the return value for typed array assignments to be the incoming value.
BUG=v8:4137 LOG=n
Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 Cr-Commit-Position: refs/heads/master@{#28954}
[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181733002 Cr-Commit-Position: refs/heads/master@{#28957}[modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/api-natives.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/api.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/bootstrapper.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/ic/ic.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/json-parser.h [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/lookup.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/lookup.h [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/objects-inl.h [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/objects.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/objects.h [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/runtime/runtime-classes.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/runtime/runtime-debug.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/runtime/runtime-object.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/runtime/runtime.h [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/src/scopeinfo.cc [modify] http://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf/test/cctest/test-debug.cc
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
