Reviewers: Igor Sheludko,
Message:
ptal
Description:
Remove ASSERT, this method can handle ExternalArrays just fine.
BUG=v8:4137
LOG=n
Please review this at https://codereview.chromium.org/1179983002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -1 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
edd758370bdb76f490e24e16b162b2f9ee98b9ff..86fb22ae36f8535a2e237b5cf93a1a8594ab2498
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4276,7 +4276,6 @@ MaybeHandle<Object>
JSObject::SetOwnPropertyIgnoreAttributes(
MaybeHandle<Object> JSObject::SetOwnElementIgnoreAttributes(
Handle<JSObject> object, uint32_t index, Handle<Object> value,
PropertyAttributes attributes, ExecutableAccessorInfoHandling
handling) {
- DCHECK(!object->HasExternalArrayElements());
Isolate* isolate = object->GetIsolate();
LookupIterator it(isolate, object, index,
LookupIterator::OWN_SKIP_INTERCEPTOR);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
