http://codereview.chromium.org/550043/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/550043/diff/1/6#newcode1386
src/arm/fast-codegen-arm.cc:1386: Apply(Expression::kValue, r0);
On 2010/01/15 05:46:58, Kevin Millikin wrote:
Just use __push(r0) here.

Done.

http://codereview.chromium.org/550043/diff/1/5
File src/fast-codegen.cc (right):

http://codereview.chromium.org/550043/diff/1/5#newcode683
src/fast-codegen.cc:683: Apply(Expression::kValue, result_register());
On 2010/01/15 05:46:58, Kevin Millikin wrote:
Use __ push(result_register()).

Done.

http://codereview.chromium.org/550043/diff/1/5#newcode687
src/fast-codegen.cc:687: Apply(Expression::kValue, result_register());
On 2010/01/15 05:46:58, Kevin Millikin wrote:
And here.

Done.

http://codereview.chromium.org/550043/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/550043/diff/1/3#newcode1351
src/ia32/fast-codegen-ia32.cc:1351: Apply(Expression::kValue, eax);
On 2010/01/15 05:46:58, Kevin Millikin wrote:
__ push(eax).

Done.

http://codereview.chromium.org/550043/diff/1/4
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/550043/diff/1/4#newcode1371
src/x64/fast-codegen-x64.cc:1371: Apply(Expression::kValue, rax);
On 2010/01/15 05:46:58, Kevin Millikin wrote:
__ push(rax).

Done.

http://codereview.chromium.org/550043
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to