LGTM on the TurboFan part with a few nits.
https://codereview.chromium.org/1179893002/diff/100001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1179893002/diff/100001/src/compiler/ast-graph-builder.cc#newcode2857
src/compiler/ast-graph-builder.cc:2857: // "delete this" is allowed.
(It could be that the "this" variable has
nit: Can we merge this comment with the one two lines above, because it
basically tries to express the same thing.
https://codereview.chromium.org/1179893002/diff/100001/src/compiler/ast-graph-builder.cc#newcode2862
src/compiler/ast-graph-builder.cc:2862: *variable->name() ==
*isolate()->factory()->this_string());
nit: This heavily relies on the fact that variable->name() is
internalized. Can we move this into a Variable::IsThisName(Isolate*)
helper so that it not spread across the codebase?
https://codereview.chromium.org/1179893002/diff/100001/src/compiler/ast-graph-builder.cc#newcode3312
src/compiler/ast-graph-builder.cc:3312: bool is_this = *variable->name()
== *isolate()->factory()->this_string();
nit: See comment above.
https://codereview.chromium.org/1179893002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
