LGTM
http://codereview.chromium.org/547024/diff/2002/2003 File src/arm/regexp-macro-assembler-arm.cc (right): http://codereview.chromium.org/547024/diff/2002/2003#newcode551 src/arm/regexp-macro-assembler-arm.cc:551: // Table is 128 bits, so all ASCII characters can be tested. 128 bytes. http://codereview.chromium.org/547024/diff/2002/2007 File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/547024/diff/2002/2007#newcode231 src/ia32/assembler-ia32.h:231: times_8 = 3, This is unused http://codereview.chromium.org/547024/diff/2002/2009 File src/ia32/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/547024/diff/2002/2009#newcode543 src/ia32/regexp-macro-assembler-ia32.cc:543: // Table is 128 bits, so all ASCII characters can be tested. bytes. http://codereview.chromium.org/547024/diff/2002/2009#newcode547 src/ia32/regexp-macro-assembler-ia32.cc:547: ASSERT_EQ(0, word_character_map[0]); // Character '\0' is not a word char. Perhaps also assert that word_character_map['a'] is 255. http://codereview.chromium.org/547024/diff/2002/2009#newcode557 src/ia32/regexp-macro-assembler-ia32.cc:557: // Table is 128 bits, so all ASCII characters can be tested. bytes http://codereview.chromium.org/547024/diff/2002/2012 File src/serialize.cc (right): http://codereview.chromium.org/547024/diff/2002/2012#newcode489 src/serialize.cc:489: "NativeRegExpMacroAssembler::word_character_bitmap"); byte! http://codereview.chromium.org/547024/diff/2002/2015 File src/x64/regexp-macro-assembler-x64.cc (right): http://codereview.chromium.org/547024/diff/2002/2015#newcode586 src/x64/regexp-macro-assembler-x64.cc:586: // Table is 128 bits, so all ASCII characters can be tested. bytes! http://codereview.chromium.org/547024/diff/2002/2015#newcode601 src/x64/regexp-macro-assembler-x64.cc:601: // Table is 128 bits, so all ASCII characters can be tested. bytes! http://codereview.chromium.org/547024
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
