http://codereview.chromium.org/542087/diff/3011/4023 File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/542087/diff/3011/4023#newcode640 src/arm/stub-cache-arm.cc:640: if (!function->IsBuiltin()) { On 2010/01/15 12:15:56, Mads Ager wrote:
Could you add a comment for these cases stating that for builtins we
don't need
to wrap the receiver, but for other functions we have to wrap the
receiver and
therefore enter the runtime system. Otherwise, I think these
conditionals will
be hard to understand later on.
Done. http://codereview.chromium.org/542087/diff/3011/4017 File src/codegen.h (right): http://codereview.chromium.org/542087/diff/3011/4017#newcode540 src/codegen.h:540: // Minor key encoding in 31 bits AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAARL. On 2010/01/15 12:15:56, Mads Ager wrote:
RL -> FI for F(lag)I(nloop) ?
Done. http://codereview.chromium.org/542087/diff/3011/4012 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/542087/diff/3011/4012#newcode8704 src/ia32/codegen-ia32.cc:8704: __ InvokeBuiltin(Builtins::TO_OBJECT, CALL_FUNCTION); On 2010/01/15 12:15:56, Mads Ager wrote:
Don't we need a frame here as in the ARM version to let the GC know
about the
return address that is pushed on the stack? This stub is called from
JavaScript
code which might move on compacting collections.
Good catch, we sure we do! http://codereview.chromium.org/542087/diff/3011/4014 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/542087/diff/3011/4014#newcode1000 src/ia32/stub-cache-ia32.cc:1000: if (!function->IsBuiltin()) { On 2010/01/15 12:15:56, Mads Ager wrote:
Add comments on these.
Done. http://codereview.chromium.org/542087/diff/3011/4021 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/542087/diff/3011/4021#newcode6990 src/x64/codegen-x64.cc:6990: __ InvokeBuiltin(Builtins::TO_OBJECT, CALL_FUNCTION); On 2010/01/15 12:15:56, Mads Ager wrote:
Don't we need a frame here as in the ARM version to let the GC know
about the
return address that is pushed on the stack? This stub is called from
JavaScript
code which might move on compacting collections.
Good catch, we sure we do! http://codereview.chromium.org/542087/diff/3011/4019 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/542087/diff/3011/4019#newcode724 src/x64/stub-cache-x64.cc:724: if (!function->IsBuiltin()) { On 2010/01/15 12:15:56, Mads Ager wrote:
Comments.
Done. http://codereview.chromium.org/542087
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
