lgtm
https://codereview.chromium.org/1185633002/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1185633002/diff/20001/src/ast.cc#newcode544
src/ast.cc:544: HandleScope scope(isolate);
Please add comment explaining why this can't be moved to the top of the
for() loop.
https://codereview.chromium.org/1185633002/diff/20001/test/mjsunit/handle-count-runtime-literals.js
File test/mjsunit/handle-count-runtime-literals.js (right):
https://codereview.chromium.org/1185633002/diff/20001/test/mjsunit/handle-count-runtime-literals.js#newcode12
test/mjsunit/handle-count-runtime-literals.js:12:
replace(/"[^"\\\n\r]*"|good|bad|none|-?\d+(?:\.\d*)?(:?[eE][+\-]?\d+)?/g,
']').
80 column limit exceeded here.
https://codereview.chromium.org/1185633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
