Reviewers: Jakob,
Description:
Fix -Wsign-compare errors in TF tests under GCC 4.9.2
[email protected]
LOG=N
BUG=
Please review this at https://codereview.chromium.org/1191433003/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+5, -5 lines):
M test/unittests/compiler/graph-reducer-unittest.cc
M test/unittests/compiler/node-unittest.cc
Index: test/unittests/compiler/graph-reducer-unittest.cc
diff --git a/test/unittests/compiler/graph-reducer-unittest.cc
b/test/unittests/compiler/graph-reducer-unittest.cc
index
8b95872a7b006b2e5525718e5a7e1818715141c1..2d54e21442d36c6c56d3f4bb4912d0eb8e1fe0be
100644
--- a/test/unittests/compiler/graph-reducer-unittest.cc
+++ b/test/unittests/compiler/graph-reducer-unittest.cc
@@ -596,12 +596,12 @@ TEST_F(GraphReducerTest, ReduceNew1) {
TEST_F(GraphReducerTest, Wrapping1) {
Node* end = graph()->NewNode(&kOpA0);
graph()->SetEnd(end);
- EXPECT_EQ(1, graph()->NodeCount());
+ EXPECT_EQ(1U, graph()->NodeCount());
A0Wrapper r(graph());
ReduceGraph(&r);
- EXPECT_EQ(2, graph()->NodeCount());
+ EXPECT_EQ(2U, graph()->NodeCount());
Node* nend = graph()->end();
EXPECT_NE(end, nend);
@@ -614,12 +614,12 @@ TEST_F(GraphReducerTest, Wrapping1) {
TEST_F(GraphReducerTest, Wrapping2) {
Node* end = graph()->NewNode(&kOpB0);
graph()->SetEnd(end);
- EXPECT_EQ(1, graph()->NodeCount());
+ EXPECT_EQ(1U, graph()->NodeCount());
B0Wrapper r(graph());
ReduceGraph(&r);
- EXPECT_EQ(3, graph()->NodeCount());
+ EXPECT_EQ(3U, graph()->NodeCount());
Node* nend = graph()->end();
EXPECT_NE(end, nend);
Index: test/unittests/compiler/node-unittest.cc
diff --git a/test/unittests/compiler/node-unittest.cc
b/test/unittests/compiler/node-unittest.cc
index
217ae6115c4b6c9f81ed3e006847b7ce010b1316..5341f697168e8175df1ae45e7cd4bbab34dd2566
100644
--- a/test/unittests/compiler/node-unittest.cc
+++ b/test/unittests/compiler/node-unittest.cc
@@ -32,7 +32,7 @@ const Operator kOp2(kOpcode2,
Operator::kNoProperties, "Op2", 2, 0, 0, 1, 0, 0);
TEST_F(NodeTest, New) {
Node* const node = Node::New(zone(), 1, &kOp0, 0, nullptr, false);
- EXPECT_EQ(1, node->id());
+ EXPECT_EQ(1U, node->id());
EXPECT_EQ(0, node->UseCount());
EXPECT_TRUE(node->uses().empty());
EXPECT_EQ(0, node->InputCount());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
