LGTM, just nits.
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/ast-graph-builder.cc#newcode1355
src/compiler/ast-graph-builder.cc:1355:
ResolveFeedbackSlot(stmt->EachFeedbackSlot()),
nit: Please pull into local variable for consistency.
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/ast-graph-builder.cc#newcode1952
src/compiler/ast-graph-builder.cc:1952: // IC unless we have it in full
code as well.
As discussed offline: It's not the responsibility of the AstGraphBuilder
to decide whether to use a runtime call or an IC.
Also, these stores are good candidates for load-store-elimination and
escape analysis, so I would strongly vote for keeping them as normal
keyed stores.
Hence I think we should just drop this TODO and address this in the
generic lowering once vectore store ICs are actually called there. Of
course I am fine with keeping a comment here saying that we just don't
have feedback slots for these stores.
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/js-operator.h#newcode302
src/compiler/js-operator.h:302: // Defines the property being loaded
from an object. This is
nit: s/loaded from an object/stored to an object/
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/js-operator.h#newcode303
src/compiler/js-operator.h:303: // used as a parameter by JSLoadProperty
operators.
nit: s/JSLoadProperty/JSStoreProperty/
https://codereview.chromium.org/1178363002/diff/20001/src/compiler/js-operator.h#newcode410
src/compiler/js-operator.h:410: const Unique<Name>& name);
nit: IMHO the name should go first or at least before the feedback.
https://codereview.chromium.org/1178363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
