LGTM
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc#newcode1187
src/parser.cc:1187: BlockState block_state(&scope_, scope);
Why was this block state added? It does not seem like it is needed for
parsing.
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc#newcode3813
src/parser.cc:3813: // TODO(wingo): Support rest parameters.
Andy implemented this last week.
https://codereview.chromium.org/1167393005/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1167393005/diff/20001/test/cctest/test-parsing.cc#newcode6617
test/cctest/test-parsing.cc:6617: "{a : a}",
Isn't this case already covered on line 6405?
https://codereview.chromium.org/1167393005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
