LGTM
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
var newIterable = {
__proto__: null,
[symbolIterator]() { return iterator; }
};
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
This hack/workaround needs a comment.
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode140
src/typedarray.js:140: for (var value of newIterable) {
var list = [...newIterable];
would work if we were OK with that dependency.
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode159
src/typedarray.js:159: // twice. Currently, that's fine, but it'll be
observable with proxies.
This comment is out of date now
https://codereview.chromium.org/1181903003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
