Thanks for the review. Fixed nits, ptal.
https://codereview.chromium.org/1182303004/diff/1/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode163
src/macros.py:163: # itself (it should really use %GetOwnProperty, but
that would be way slower).
On 2015/06/15 12:09:11, rossberg wrote:
Is this comment still needed? It seems to work that way now.
Removed.
https://codereview.chromium.org/1182303004/diff/1/src/macros.py#newcode165
src/macros.py:165: macro NEW_PRIVATE_OWN(name) =
(%CreatePrivateSymbol(name));
On 2015/06/15 12:09:11, rossberg wrote:
Rename this to NEW_PRIVATE
Done.
https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/harmony/private.js
File test/mjsunit/harmony/private.js (right):
https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/harmony/private.js#newcode244
test/mjsunit/harmony/private.js:244: // Private symbols key
own-properties..
On 2015/06/15 12:09:11, rossberg wrote:
Nit: extra period
Done.
https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/own-symbols.js
File test/mjsunit/own-symbols.js (right):
https://codereview.chromium.org/1182303004/diff/1/test/mjsunit/own-symbols.js#newcode1
test/mjsunit/own-symbols.js:1: // Copyright 2014 the V8 project authors.
All rights reserved.
On 2015/06/15 12:09:11, rossberg wrote:
This should be merged into harmony/private.js
Done.
https://codereview.chromium.org/1182303004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
