Reviewers: jarin, stichnot, jvoung, Mircea Trofin,
Message:
Created Revert of Decompiler improvements.
Description:
Revert of Decompiler improvements. (patchset #2 id:20001 of
https://codereview.chromium.org/1177123002/)
Reason for revert:
Code printout has become unreadable. Offsets are printed in decimal numbers
everywhere else. This is inconsistent with the rest of the code-base. Some
examples are tables for deoptimization data, safepoints and exception
handlers.
I would be fine with this change if _all_ tracing would be adapted. But
there
are _many_ places to touch.
Original issue's description:
Decompiler improvements.
The main motivation is simplifying profiling activities:
1) Use hex instead of decimal for offsets, just like perf does. This
affects --print-opt-code
2) When printing block information, indicate loop information: if
block is header, where the end is; if block is in a loop, where the
loop starts. This affects --code-comments.
Using --print-opt-code --code-comments, and cross-referencing with data
obtained from perf, one may now find the block a hotspot belongs to
without needing to do hex2dec/dec2hex conversions. Once found, loop info
is available locally, on the block.
BUG=
Committed: https://crrev.com/32f4bd659d38eb5485eedb1d0dd236ff1bdc01d5
Cr-Commit-Position: refs/heads/master@{#28964}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1188093002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -25 lines):
M src/compiler/code-generator.cc
M src/disassembler.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
