Thanks a lot for fixing this!
I see that js files are deleted, but not added. Did you forget to "git add"
the
moved js files in the new pcre directory?
https://codereview.chromium.org/1183743003/diff/1/LICENSE
File LICENSE (right):
https://codereview.chromium.org/1183743003/diff/1/LICENSE#newcode29
LICENSE:29: Further license information can be found in individual
sub-directories.
Could you please list the sub-directories here?
src/third_party/, test/??
https://codereview.chromium.org/1183743003/diff/1/src/third_party/valgrind/LICENSE
File src/third_party/valgrind/LICENSE (right):
https://codereview.chromium.org/1183743003/diff/1/src/third_party/valgrind/LICENSE#newcode1
src/third_party/valgrind/LICENSE:1: /* -*- c -*-
Can we remove the C++ comments and unindent the text?
https://codereview.chromium.org/1183743003/diff/1/src/third_party/vtune/LICENSE
File src/third_party/vtune/LICENSE (right):
https://codereview.chromium.org/1183743003/diff/1/src/third_party/vtune/LICENSE#newcode3
src/third_party/vtune/LICENSE:3: /*
Remove the comment?
https://codereview.chromium.org/1183743003/diff/1/test/mjsunit/third_party/regexp-pcre/LICENSE
File test/mjsunit/third_party/regexp-pcre/LICENSE (right):
https://codereview.chromium.org/1183743003/diff/1/test/mjsunit/third_party/regexp-pcre/LICENSE#newcode2
test/mjsunit/third_party/regexp-pcre/LICENSE:2: // ------------
Remove the "//" prefix?
https://codereview.chromium.org/1183743003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
