The goal was to make correlating with "perf" output easy, so offsets are sufficient in that case. Would a flag to enable only offsets in hex address your concern? Something like --decomp-offsets-hex.
If we feel we wanted a master switch instead (all numbers to hex), we could call the flag something like "--use-hex", and gradually (over many CLs) change other traces. But I don't know if we have scenarios asking for that just yet. Thoughts? Thanks! On Tue, Jun 16, 2015 at 03:36 <[email protected]> wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1188093002/ by [email protected]. > > The reason for reverting is: Code printout has become unreadable. Offsets > are > printed in decimal numbers everywhere else. This is inconsistent with the > rest > of the code-base. Some examples are tables for deoptimization data, > safepoints > and exception handlers. I would be fine with this change if _all_ tracing > would > be adapted. But there are _many_ places to touch.. > > https://codereview.chromium.org/1177123002/ > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
